[PATCH] D78180: [X86][MC][NFC] Reduce the parameters of functions in X86MCCodeEmitter(Part I)

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 15 02:41:51 PDT 2020


skan added a comment.

In D78180#1983011 <https://reviews.llvm.org/D78180#1983011>, @pengfei wrote:

> It's better to add NFC in the title.
>  The type of TSFlags is uint64_t instead of const uint64_t, is it possible this value been changed during function call?


As far as I know, `TSFlags` is constant during function call. (At least in this file it's constant)  @craig.topper


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78180/new/

https://reviews.llvm.org/D78180





More information about the llvm-commits mailing list