[PATCH] D78113: Fix DWARFDataExtractor::getRelocatedValue near EOF

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 15 00:30:07 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.

LGTM, although there's a typo in your summary (a missing closing ')') which should be fixed if you are using it as the commit message.



================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDataExtractorTest.cpp:65
+  EXPECT_THAT_ERROR(C.takeError(),
+                    FailedWithMessage("unexpected end of data at offset 0x4"));
+}
----------------
Don't think it needs fixing in this commit, since it's not really related to the change, but an offset of 0x4 here is confusing, given that the end of data is at 0x6.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78113/new/

https://reviews.llvm.org/D78113





More information about the llvm-commits mailing list