[PATCH] D76585: [PowerPC] Require NSZ flag for c-a*b to FNMSUB

Qiu Chaofan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 14 20:40:15 PDT 2020


qiucf added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:15783
+
+    if (N0Cost < N1Cost)
+      return DAG.getNode(Opc, SDLoc(Op), VT, NegN0, N1, NegN2, Flags);
----------------
steven.zhang wrote:
> Please refer to how we did for FMA. i.e. Your implementation has problems when A=neutral, B=neutral, and C=cheaper
Thanks, I was not aware of `(A=neutral && B=neutral && C=cheaper) => cheaper`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76585/new/

https://reviews.llvm.org/D76585





More information about the llvm-commits mailing list