[PATCH] D77788: [PowerPC][Future] Enable Tail Calls for PC Relative Code

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 14 20:40:14 PDT 2020


amyk added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5580
+      // Address Node. The callee could be an indirect tail call in which
+      // case the SDValue for callee could be a load (to load the address
+      // of a function pointer) or it may be a register copy (to move the
----------------
s/for callee/for the callee


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5583
+      // address of the callee from a function parameter into a virtual
+      // register). It may also be an ExtrernalSymbolSDNode (ex memcopy).
+      assert((Subtarget.isUsingPCRelativeCalls() ||
----------------
s/ExtrernalSymbolSDNode/ExternalSymbolSDNode


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77788/new/

https://reviews.llvm.org/D77788





More information about the llvm-commits mailing list