[PATCH] D77424: [XCOFF][AIX] Relocation support for SymB

[Jason Liu via Phabricator via llvm-commits]

jasonliu marked an inline comment as done.
jasonliu added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-reloc-symb.mir:24
+    renamable $r3 = LI 2
+    STW killed renamable $r3, -12, $r1
+...  
----------------
hubert.reinterpretcast wrote:
> I'm a bit disturbed by the weirdness of this function. I suggest the following.
> ```
> ---
> name:            foo
> alignment:       16
> tracksRegLiveness: true
> jumpTable:
>   kind:            label-difference32
>   entries:
>     - id:              0
>       blocks:          [ '%bb.0' ]
> body:             |
>   bb.0:
>     successors: %bb.0(0x20000000)
>     liveins: $r2
>     renamable $r3 = LWZtoc %jump-table.0, $r2 :: (load 4 from got)
>     BLR implicit $lr, implicit $rm, implicit killed $r3
> ...
> ```
Thanks. It is much better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77424/new/

https://reviews.llvm.org/D77424