[PATCH] D78147: [LICM] Try to merge debug locations when sinking

Tue Apr 14 14:08:42 PDT 2020

davide added a comment.

In D78147#1981862 <https://reviews.llvm.org/D78147#1981862>, @dblaikie wrote:

> Do you have any detailed data to refute the claim in the original comment "given that the inserted loads/stores have little relation to the original loads/stores".

Is the wrong line info at `-Og` outlined in the bug report enough? Or you'd like to have more? I'm not sure how to get these, given the original code to preserve debug info has been committed in 2011, and I'm apparently the first one to formalize this bug :)

> Is this loop over the "original loads and stores"?

Yes.

> & maybe some comments in the test case describing what got merged and why the merged result is the desired one?

Fair.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78147/new/

https://reviews.llvm.org/D78147