[PATCH] D78050: Introduce `__sanitizer::ArrayRef<T>` type.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

Don't suppose there's any sane way to reuse any part of the main llvm version? Might at least be worth a few comments encouraging future developers to try to keep this mostly aligned with the llvm one? (maybe document broadly the features/etc that are omitted from this version but present in the llvm one)

Is this more or less copy/paste, except for some features that aren't supportable/suitable for this usage?



================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_mutable_array_ref.h:81
+    CHECK_LE(n, size());
+    T *slice_begin = const_cast<T *>(begin()) + n;
+    uptr slice_size = size() - n;
----------------
Going to use `data()` here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78050/new/

https://reviews.llvm.org/D78050