[PATCH] D78143: [MLIR] Pass options to ParallelLoopCollapsing constructor.

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/include/mlir/Transforms/Passes.h:18
 #include "mlir/Support/LLVM.h"
+#include "third_party/llvm/llvm-project/llvm/include/llvm/ADT/ArrayRef.h"
+
----------------
This looks wrong?


================
Comment at: mlir/lib/Transforms/ParallelLoopCollapsing.cpp:22
 namespace {
+
 struct ParallelLoopCollapsing
----------------
This looks unrelated.


================
Comment at: mlir/lib/Transforms/ParallelLoopCollapsing.cpp:26
+  ParallelLoopCollapsing() = default;
+  ParallelLoopCollapsing(const ParallelLoopCollapsing &){};
+  ParallelLoopCollapsing(ArrayRef<unsigned> collapsedIndices0,
----------------
This constructor should be unnecessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78143/new/

https://reviews.llvm.org/D78143