[PATCH] D77065: [ARM][MVE] Add VHADD and VHSUB patterns
Dave Green via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 14 10:46:19 PDT 2020
dmgreen added a comment.
Seems OK, from what I can tell. And http://volta.cs.utah.edu:8080/z/8mUFbh says this is OK. My fuzzer really isn't going to like it, but that's a separate issue!
================
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:2089
+
+def addnuw : PatFrag<(ops node:$lhs, node:$rhs),
+ (add node:$lhs, node:$rhs), [{
----------------
Can you add a comment about how this instruction is using a higher bitwidth type, and the nowrap makes sure we don't overflow when only dealing with lower bitwidth?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77065/new/
https://reviews.llvm.org/D77065
More information about the llvm-commits
mailing list