[PATCH] D77635: [LV] Vectorize with FoldTail when Primary Induction is absent

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 14 08:33:19 PDT 2020


SjoerdMeijer added a comment.

FYI: I have extracted the ARM test changes from  D76838 <https://reviews.llvm.org/D76838> and have committed that in 9633fc14aef7 <https://reviews.llvm.org/rG9633fc14aef7ee3da3b9ffbd84dd85b06cbcb8d7>. Just saying also just in case you do end up reverting this, then that would need some changes. Probably the easiest is to change the check-prefixes to `--check-prefixes=COMMON`, because then it won't be checking much which is fine in that case; I will pick this up later, also because they will need some work later. I have a suspicion `sgt_no_loopguard` is miscompiled, but I need to look closer. Anyway, these were the tests that I thought were good to have, and with them in tree it is easier to talk about them.

Some of these tests also show that this change does not support some of the cases that was supported by D76838 <https://reviews.llvm.org/D76838>, and I will be looking at that, hence I will be touching test/Transforms/LoopVectorize/ARM/tail-folding-counting-down.ll again sooner or later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77635/new/

https://reviews.llvm.org/D77635





More information about the llvm-commits mailing list