[PATCH] D77554: [DWARFDebugLine] Check for (EOF) errors when parsing v5 content descriptors

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 14 07:27:38 PDT 2020


labath marked an inline comment as done.
labath added inline comments.


================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/debug_line_short_prologue.s:1-2
+# Test cases when we run into the end of section while parsing a line table
+# prologue.
+
----------------
jhenderson wrote:
> Something I'm trying to encourage is using "##" for comment markers in lit tests using assembly/YAML etc, to distinguish from the RUN and CHECK lines. I find it makes them stand out better. Would you mind changing this here?
Yeah, I think that's a good convention -- I just keep forgetting about that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77554/new/

https://reviews.llvm.org/D77554





More information about the llvm-commits mailing list