[PATCH] D77848: [llvm-dwarfdump] Interface cleanup. NFC

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 14 03:41:06 PDT 2020


jhenderson added a comment.

I'd have rejected this change, partly, if I'd seen this before the commit. I REALLY hate it when definitions and declarations for functions are not in matching header/source files. Why did the declarations relating to the SectionSizes.cpp stuff get moved into an unrelated header?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77848/new/

https://reviews.llvm.org/D77848





More information about the llvm-commits mailing list