[PATCH] D77231: [lld] Support --lto-emit-asm and --plugin-opt=emit-asm

[Hongtao Yu via Phabricator via llvm-commits]

hoyFB added inline comments.


================
Comment at: lld/ELF/Options.td:528
+def plugin_opt_emit_asm: F<"plugin-opt=emit-asm">,
+  Alias<lto_emit_asm>, HelpText<"Alias for -lto-emit-asm">;
 def: J<"plugin-opt=jobs=">, Alias<thinlto_jobs>, HelpText<"Alias for -thinlto-jobs">;
----------------
MaskRay wrote:
> hoyFB wrote:
> > MaskRay wrote:
> > > MaskRay wrote:
> > > > `--lto-emit-asm`
> > > This is not done.
> > Yeah, I overlooked this. I'm a bit confused here. I'm seeing every other lto switche has only one dash. What's the convention here?
> I fixed `Alias for ` in 42bb5cc502da0e01e5e714800dbec7d13603d399.
> 
> GNU ld has very loose parsing rules. It accepts either single-dash or double-dash options. For compatibility we have to do the same. For commonly used single-dash options e.g. -shared -pie (Their compiler driver counterparts use this form), I stick with them. For everything unclear, I use the double dash form.
> 
> `-lto-...` is bad because it conflicts with `-l` 
Gotcha, thanks for the explanation. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77231/new/

https://reviews.llvm.org/D77231