[PATCH] D77580: [llvm-objdump] Fix incomplete relocation output for -D -r mode

Mon Apr 13 14:48:07 PDT 2020

jasonliu marked an inline comment as done.
jasonliu added a comment.

In D77580#1978986 <https://reviews.llvm.org/D77580#1978986>, @saugustine wrote:

> As written, this test writes to the current directory, which assumes that the current directory is writable, but that is not true in all builds. I have committed 215e6bfcfb5af7713ec348f679c7be4d2f32dc82 <https://reviews.llvm.org/rG215e6bfcfb5af7713ec348f679c7be4d2f32dc82> to fix.

@saugustine Thanks for the quick fix.

================
Comment at: llvm/test/tools/llvm-objdump/MachO/disassemble-relocs-data-x86_64.test:2
+# REQUIRES: x86-registered-target
+# RUN: yaml2obj < %s -o %.o
+# RUN: llvm-objdump -D -r %.o | FileCheck %s
----------------
MaskRay wrote:
> This should be `yaml2obj %s -o %.o`
> 
> (yaml2obj does not record the source filename in the output, which may make FileCheck tests brittle sometimes.)
Thanks for pointing that out. Addressed in post commit: rGd5143e3f102a91599682fc630205e5c6fec58c76.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77580/new/

https://reviews.llvm.org/D77580