[PATCH] D77858: [llvm-xray] Add llvm-xray extract support for 32 bit ARM

Max Sherman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 13 14:07:53 PDT 2020


johnislarry added a comment.

Ah yeah, I see the assertion you're talking about.  It looks like the RelocationResolver for arm is incomplete maybe?  I've attached a picture of something I tried, but down the road it can't find the address for the symbol.

F11726277: Screenshot 2020-04-13 17.00.19.png <https://reviews.llvm.org/F11726277>

It also looks like this doesn't affect results in release builds because later when we call RelocateOrElse, we always have an address, so we ignore the relocations entirely.

I would appreciate you taking it from here, but please let me know if it falls off your radar so I can pick it back up!

At FB we're starting to use xray on Android to better understand our native code execution, so definitely interested in getting ARM variants working!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77858/new/

https://reviews.llvm.org/D77858





More information about the llvm-commits mailing list