[PATCH] D77991: [llvm][NFC] CallSite removal from inliner-related files

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/lib/CodeGen/SafeStack.cpp:346-347
         // the function being called.
-        ImmutableCallSite::arg_iterator B = CS.arg_begin(), E = CS.arg_end();
-        for (ImmutableCallSite::arg_iterator A = B; A != E; ++A)
+        auto B = CS.arg_begin(), E = CS.arg_end();
+        for (auto A = B; A != E; ++A)
           if (A->get() == V)
----------------
Probably commit things like this independently (before/after this refactor, whichever suits better) without precommit review.


================
Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1662
   // FIXME: we don't inline callbr yet.
-  if (isa<CallBrInst>(TheCall))
+  if (isa<CallBrInst>(&CB))
     return InlineResult::failure("We don't inline callbr yet.");
----------------
You don't need to add a & here, I think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77991/new/

https://reviews.llvm.org/D77991