[PATCH] D78032: [llvm-objdump] Default to the "apple-latest" mcpu when disassembling arm64 Mach-O binaries

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 13 12:26:35 PDT 2020


MaskRay added a comment.

In D78032#1978339 <https://reviews.llvm.org/D78032#1978339>, @mtrent wrote:

> In D78032#1978249 <https://reviews.llvm.org/D78032#1978249>, @MaskRay wrote:
>
> > Can you clarify whether the intention is:
> >
> > - For MachOObjectFile::getArchTriple <https://github.com/llvm/llvm-project/blob/master/llvm/lib/Object/MachOObjectFile.cpp#L2598>, we want to use a conservative arch flag, because it may be used by both producers and consumers. We don't want to impose an arch feature restriction for binaries created by the producers.
> > - For llvm-objdump and may be llvm-nm/llvm-size, the read-only consumers, we want to use the latest arch flag so that all features can be decoded correctly.
>
>
> I don't understand the question?


Is it possible to make the (defaulting mcpu to "apple-latest") decision in a library, instead of in llvm-objdump and other individual tools?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78032/new/

https://reviews.llvm.org/D78032





More information about the llvm-commits mailing list