[PATCH] D77812: [flang] Semantic checks for OpenMP combined constructs.

Mon Apr 13 11:18:16 PDT 2020

DavidTruby marked an inline comment as done.
DavidTruby added inline comments.

================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:16

+static constexpr inline OmpClauseSet doAllowedClauses{OmpClause::PRIVATE,
+    OmpClause::FIRSTPRIVATE, OmpClause::LASTPRIVATE, OmpClause::LINEAR,
----------------
klausler wrote:
> DavidTruby wrote:
> > klausler wrote:
> > > What do you think `inline` is going to do for you when `static` also appears?
> > I'm really using `inline` here as a hint to the reader/future contributors of the intent of these variables. It's certainly not necessary, as it is implied by `constexpr` and the semantics it provides on top of static aren't necessary here.
> > I'm happy to remove it but I do think it signals the intent of what I'm doing.
> What is the hint to the reader?
That the variables shouldn't be used in any context that would cause them to have to exist in the binary

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77812/new/

https://reviews.llvm.org/D77812