[PATCH] D78039: Define SDBM key methods in its own cpp file.

[River Riddle via Phabricator via llvm-commits]

rriddle accepted this revision.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/include/mlir/Dialect/SDBM/SDBMDialect.h:22
 
+  // Since there are no other virtual methods in this derived class, override
+  // the destructor so that key methods get defined in the corresponding
----------------
Please use /// for top-level comments.


================
Comment at: mlir/lib/Dialect/SDBM/SDBMDialect.cpp:9
+//
+// Dialect level definitions.
+//
----------------
nit: This comment block can probably just be removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78039/new/

https://reviews.llvm.org/D78039