[PATCH] D77687: [SelectionDAG] Fix usage of Align constructing MachineMemOperands

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 13 10:12:26 PDT 2020


RKSimon added a comment.

Do you intend to split the commits at all?



================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:437
   SDValue Ptr = ST->getBasePtr();
-  unsigned Alignment = ST->getAlignment();
   MachineMemOperand::Flags MMOFlags = ST->getMemOperand()->getFlags();
----------------
Incidently, should we tag MemSDNode::getAlignment() as LLVM_ATTRIBUTE_DEPRECATED now? We already have this for MemSDNode::getOriginalAlignment().


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77687/new/

https://reviews.llvm.org/D77687





More information about the llvm-commits mailing list