[PATCH] D78012: [MLIR] Fix dominance info method - properlyDominates
Chris Lattner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 13 09:07:09 PDT 2020
lattner added a comment.
Thank you for tackling this Uday!
The right check here is to see if the block isReachableFromEntry (which is a method of dominator set), not hasNoPredecessors().
It could be part of an unreachable cycle or something like that, in which the same (lack of) dominance properties hold.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78012/new/
https://reviews.llvm.org/D78012
More information about the llvm-commits
mailing list