[PATCH] D74534: [Float2Int] Make iteration over Roots deterministic

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 13 06:25:21 PDT 2020


spatel added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/Float2Int.cpp:527-529
+  findRoots(F, DT);
 
+  walkBackwards();
----------------
Isn't the change use the member variable directly (rather than passing a param to it) truly NFC? 
IIUC, we should make that change first (no need for pre-commit review).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74534/new/

https://reviews.llvm.org/D74534





More information about the llvm-commits mailing list