[PATCH] D77999: Reimplement mlir::Identifier to be a wrapper around 'StringMapEntry' instead of a wrapper around a 'const char'. This makes it so strref() can be computed without calling strlen, which is more efficient and less error-prone. While here...

Sun Apr 12 22:27:30 PDT 2020

lattner created this revision.
Herald added subscribers: llvm-commits, frgossen, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini.
Herald added a reviewer: rriddle.
Herald added a project: LLVM.

..., reimplement DenseMapInfo<mlir::Identifier>::getHashValue in terms of mlir::hash_value(Identifier).

Both of these improvements were suggested by River, thanks!

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77999

Files:
  mlir/include/mlir/IR/Identifier.h
  mlir/lib/IR/MLIRContext.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77999.256924.patch
Type: text/x-patch
Size: 4422 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200413/e7ee5e24/attachment.bin>

[PATCH] D77999: Reimplement mlir::Identifier to be a wrapper around 'StringMapEntry*' instead of a wrapper around a 'const char*'. This makes it so strref() can be computed without calling strlen, which is more efficient and less error-prone. While here...

[PATCH] D77999: Reimplement mlir::Identifier to be a wrapper around 'StringMapEntry' instead of a wrapper around a 'const char'. This makes it so strref() can be computed without calling strlen, which is more efficient and less error-prone. While here...