[PATCH] D76908: [lld-macho] Add support for emitting dylibs with a single symbol

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM



================
Comment at: lld/MachO/SyntheticSections.cpp:154
+
+  auto *sym = exported.front();
+  os << (char)0; // Indicates non-leaf node
----------------
`auto *` -> `const Defined *`


================
Comment at: lld/MachO/Writer.cpp:334
+  default:
+    error("unhandled output file type");
+    return;
----------------
When we reach here, it's an internal error. So this line should be `llvm_unreachable` rather than `error`.


================
Comment at: lld/MachO/Writer.cpp:374
+  default:
+    error("unhandled output file type");
+    return;
----------------
Ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76908/new/

https://reviews.llvm.org/D76908