[PATCH] D77978: [ViewCFG] Allow printing edge weights in debuggers

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 12 14:25:16 PDT 2020


wenlei accepted this revision.
wenlei added a comment.
This revision is now accepted and ready to land.

Thanks for the change - this comes in handy for debugger. LGTM.



================
Comment at: llvm/include/llvm/Analysis/CFGPrinter.h:71
+    EdgeWeights = !!BPI; // Print EdgeWeights when BPI is available.
+    RawWeights = !!BFI;  // Print RawWeights when BFI is available.
   }
----------------
nit: when raw weights is printed, both BFI and BPI is needed. The comment is slightly confusing, though functionality-wise it's fine as `EdgeWeights` is always checked before `RawWeights`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77978/new/

https://reviews.llvm.org/D77978





More information about the llvm-commits mailing list