[PATCH] D77512: [ELF] Add --warn-backrefs-exclude=<glob>

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 12 08:32:20 PDT 2020


MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: lld/ELF/Options.td:406
 
+defm warn_backrefs_exclude
+    : Eq<"warn-backrefs-exclude",
----------------
tmsriram wrote:
> Just a drive by observation.  Why not --no-warn-backrefs=?  Basically the same semantics except --no-warn-backrefs= instead of --warn-backrefs-exclude=
`--no-warn-backrefs` is the opposite of `--warn-backrefs`.

Adding `--no-warn-backrefs=` may be confusing. A different stem name makes it slightly clearer there is no order dependency between `--warn-backrefs-exclude=` and `--warn-backrefs`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77512/new/

https://reviews.llvm.org/D77512





More information about the llvm-commits mailing list