[PATCH] D77869: [VPlan] Introduce VPWidenSelectRecipe (NFC).

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 12 07:27:53 PDT 2020


fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:6940
+  auto *SI = dyn_cast<SelectInst>(I);
+  if (!SI)
+    return nullptr;
----------------
gilr wrote:
> SI is not used beyond this point until recipe construction. Better to either use it consistently instead of I or only check isa<> here and cast<> at recipe construction.
changed to use it throughout.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77869/new/

https://reviews.llvm.org/D77869





More information about the llvm-commits mailing list