[PATCH] D77216: [llvm-readobj] - Fix crashes and misbehaviors when reading strings from broken string tables.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 11 21:52:03 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/dynamic-malformed.test:336
+    Address: 0x1000
+    Content: '746573742e736f' ## "test.so", there is no expected null symbol at the end.
+  - Type:    Fill
----------------
Not terminated by a NUL.

or

Not null terminated


================
Comment at: llvm/test/tools/llvm-readobj/ELF/dynamic-malformed.test:364
+        Value: 0
+Symbols: []
+ProgramHeaders:
----------------
This can be omitted


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77216/new/

https://reviews.llvm.org/D77216





More information about the llvm-commits mailing list