[PATCH] D77895: [x86] use vector instructions to lower FP->int->FP casts

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 11 04:15:03 PDT 2020


RKSimon accepted this revision.
RKSimon added a comment.

LGTM, cheers - I'm not sure whats stopping us handling the float/double-int-double/float conversions as well in this patch though.



================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:19158
+  SDValue X = CastToInt.getOperand(0);
+  // TODO: Allow size-changing from source to dest (double -> i32 -> float)
+  if (X.getSimpleValueType() != VT ||
----------------
What's stopping us getting this done in this patch as well?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77895/new/

https://reviews.llvm.org/D77895





More information about the llvm-commits mailing list