[PATCH] D77935: [MLIR][NFC] Builder InsertionGuard::saveInsertionPoint -> savedInsertionPoint

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 11 01:02:19 PDT 2020


rriddle requested changes to this revision.
rriddle added a comment.
This revision now requires changes to proceed.

I'm not +1 on this change. The function is a verb, i.e. it is requesting that the builder "save" the current insertion point inside of an InsertionPoint and return it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77935/new/

https://reviews.llvm.org/D77935





More information about the llvm-commits mailing list