[PATCH] D77756: [SVE] Remove calls to isScalable from Transforms

[Christopher Tetreault via Phabricator via llvm-commits]

ctetreau marked an inline comment as done.
ctetreau added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp:593
   Type *Dummy;
-  if (!Ty->isIntegerTy() && Ty->isSized() &&
-      !(Ty->isVectorTy() && cast<VectorType>(Ty)->isScalable()) &&
+  if (!Ty->isIntegerTy() && Ty->isSized() && isa<FixedVectorType>(Ty) &&
       DL.isLegalInteger(DL.getTypeStoreSizeInBits(Ty)) &&
----------------
efriedma wrote:
> This doesn't appear to be equivalent.
(NOT ((is vector) AND (is scalable))) => true for all values except scalable vectors
(is fixed width vector) => true only for fixed width vectors

I'll fix it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77756/new/

https://reviews.llvm.org/D77756