[PATCH] D77819: [lit] Add SKIPPED test result category

Fri Apr 10 15:04:22 PDT 2020

yln marked an inline comment as done.
yln added a comment.

In D77819#1974995 <https://reviews.llvm.org/D77819#1974995>, @jdenny wrote:

> It think it would be messy: run the lit test suite in the background redirecting to a file, record the PID, poll that file in the foreground until expected passes appear, and then kill -SIGINT.  Very slow tests should be skipped.  It works from my bash shell, but I'm not sure about portability.
>
> For now, your `-max-failures` tests are a race-free, portable way to exercise at least one code path for skipped tests, so I would not object if you felt that was sufficient.

Yes, I would like to spend my time on other improvements ;)

================
Comment at: llvm/utils/lit/tests/max-time.py:3
+#
+# RUN: %{lit} %{inputs}/max-time --max-time=1 2>&1  |  FileCheck %s
+
----------------
jdenny wrote:
> On heavily loaded test systems, is there a chance of a race here?
Yes, race is between `--max-time=1` and `sleep 5` in [slow.txt].  I will increase 5 to 60 when landing.  That should work for all practical purposes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77819/new/

https://reviews.llvm.org/D77819