[PATCH] D77188: Fix lifetime call in landingpad blocking Simplifycfg pass

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 10 10:48:00 PDT 2020


rnk added a comment.

In D77188#1973342 <https://reviews.llvm.org/D77188#1973342>, @jdoerfert wrote:

> > By @lebedev.ri via email:
> >  This likely should ideally also look past new attribute bundles/ephemeral values?
>
> I agree. We need to unify these things instead of matching them explicitly, asking for droppable or ephemeral values. The interface is probably needs to provide some choices, e.g., for debug information, but I think by default treating all intrinsics we can safely remove as droppable should get as almost there.


Sounds good, but such a classification tool does not exist, and this was Zequan's first patch, so I didn't ask him to create this abstraction.

Building this concept (meta-instructions from codegen seem similar) isn't easy. It's not legal to move code past a lifetime intrinsic, for example. So it's hard to nail down the exact semantics of what we're looking for here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77188/new/

https://reviews.llvm.org/D77188





More information about the llvm-commits mailing list