[PATCH] D77852: Outline CFI Instructions in Tail Calls

Andrew Litteken via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 9 20:53:01 PDT 2020


AndrewLitteken marked an inline comment as done.
AndrewLitteken added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/machine-outliner-cfi.mir:6
+# it requires fixups. Show that we don't include CFI instructions in non
+# tail call outlined sequences right now.
 
----------------
paquette wrote:
> This testcase is the same as the new one you're adding, right?
> 
> I don't think we need both testcases if so. I think it would be better to just keep this one and not add a new, identical test.
This is the old test so that it actually shows this.  The previous test could outline the CFI instruction, this one should not.  The comments are the same because I was copy pasting the file to get the testing framework correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77852/new/

https://reviews.llvm.org/D77852





More information about the llvm-commits mailing list