[PATCH] D77030: [RISCV] refactor FeatureRVCHints to make ProcessorModel more intuitive

Kuan Hsu Chen (Zakk) via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 9 19:36:05 PDT 2020


khchen added a comment.

I agree negative features is not intuitive, but HINT instruction default is legal and supported, in other words, it mean the disabling HINT instruction is a feature, right?
There were also negative features in other backend. (grep `FeatureNo`) so we are not first support it.
For sure, I won’t insist on doing this, I feel it's just a friendly trade-off between user and developer.
Thanks.  :P


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77030/new/

https://reviews.llvm.org/D77030





More information about the llvm-commits mailing list