[PATCH] D77821: [Flang][OpenMP] Avoid abort when collapse clause value is negative

Thu Apr 9 17:26:20 PDT 2020

clementval added a comment.

In D77821#1973046 <https://reviews.llvm.org/D77821#1973046>, @ichoyjx wrote:

> In D77821#1972684 <https://reviews.llvm.org/D77821#1972684>, @jdoerfert wrote:
>
> > Why is this not caught by the parser? I mean, this seems a lot of code to accommodate negative values and some conditions to not trip over them even though they are never allowed/useful.
>
>
> The argument is only an Expr to the parser. To check whether it's an integer or constant, we need to do that in Semantics.

Thanks for the review. I just updated the patch with correct clang-format. If you have write rights, can you land the patch. I do not have rights now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77821/new/

https://reviews.llvm.org/D77821