[PATCH] D77810: [VPlan] Drop redundant private: at beginning of class defs (NFC).

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 9 15:49:15 PDT 2020


Ayal added a comment.

Thanks for cleaning this up. There are additional VPlan classes in other files with such a redundant 'private'; best keep them all consistent.

While we're at it, there are other cases with a redundant 'public', breaking the "`struct` should be used when //all //members are declared public" rule of https://llvm.org/docs/CodingStandards.html#use-of-class-and-struct-keywords



================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:79
 /// In what follows, the term "input IR" refers to code that is fed into the
-/// vectorizer whereas the term "output IR" refers to code that is generated by
+// vectorizer whereas the term "output IR" refers to code that is generated by
 /// the vectorizer.
----------------
Retain the 3rd slash?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77810/new/

https://reviews.llvm.org/D77810





More information about the llvm-commits mailing list