[PATCH] D77740: [CMake] Add a warning message to prepare the upcoming upgrade to CMake 3.13.4

Thu Apr 9 15:48:50 PDT 2020

smeenai added a comment.

In D77740#1970819 <https://reviews.llvm.org/D77740#1970819>, @tstellar wrote:

> In D77740#1970516 <https://reviews.llvm.org/D77740#1970516>, @phosek wrote:
>
> > The way I interpreted the email thread is that we would bump the minimum CMake version to 3.13.4 after the the 11.0 branch which will be presumably in July.
> >
> > I'm also fine with updating now, but if we do that we need to decide whether we're going to upgrade to 3.10.2 immediately or wait 15 days until the Ubuntu 20.04 LTS release and then move immediately to 3.13.4. However, that might be a bit too aggressive: it's unlikely that everyone is on going to upgrade on day one.
> >
> > We could also consider raising the minimum version now to 3.10.2, and then raise it again to 3.13.4 after the 11.0 branch, which gives everyone ~3 months to upgrade.
>
>
> I am in favor of doing this.  Bumping now to 3.10.2 and then bump to 3.13.4 after the 11.0 branch.

How much churn do you think two CMake upgrades, one shortly after the other, will cause, vs. a single upgrade? Is it worth the benefits? Also, what's the best way to communicate that the LLVM 11 release will up the CMake requirement?

If we decide to go down this route, we should probably do something like the toolchain version checks, where they have a minimum version and a soft error version. In our case here, the minimum would be 3.10.2 and the soft error version would be 3.13.4.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77740/new/

https://reviews.llvm.org/D77740