[PATCH] D77812: [flang] Semantic checks for OpenMP combined constructs.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 9 13:13:39 PDT 2020


jdoerfert added inline comments.


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:30
+    OmpClause::PRIVATE, OmpClause::FIRSTPRIVATE, OmpClause::SHARED,
+    OmpClause::COPYIN, OmpClause::REDUCTION};
+static constexpr inline OmpClauseSet parallelAllowedOnceClauses{
----------------
This is the kind of information I would like to share with `OMPKinds.def`. While we need to add the "once" flag there the interface in `OMPConstants.h` is already there to be reused:

```
  /// Return true if \p C is a valid clause for \p D in version \p Version.                                             
  bool isAllowedClauseForDirective(Directive D, Clause C, unsigned Version); 
```



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77812/new/

https://reviews.llvm.org/D77812





More information about the llvm-commits mailing list