[PATCH] D77283: scudo: Add support for diagnosing memory errors when memory tagging is enabled.

Mitch Phillips via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 9 12:56:35 PDT 2020


hctim added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/primary64.h:253
+      B.BlockSize = SizeClassMap::getSizeByClassId(ClassId);
+      B.BlockBegin = B.RegionBegin + sptr(Ptr - B.RegionBegin) /
+                                         sptr(B.BlockSize) * B.BlockSize;
----------------
```
primary64.h:253:64: error: implicit conversion changes signedness: 'long' to 'unsigned long' [-Werror,-Wsign-conversion]
      B.BlockBegin = B.RegionBegin + sptr(Ptr - B.RegionBegin) /
                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~^
```




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77283/new/

https://reviews.llvm.org/D77283





More information about the llvm-commits mailing list