[PATCH] D76459: [SCCP] Use SimplifyBinOp for non-integer constant/expressions & overdef.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 9 12:26:35 PDT 2020


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM

I guess you're right that it doesn't cause any practical problem at the moment.  If we actually resolve a value to a single constant, we can treat it as a simple constant in SCCP.  The model is technically wrong as we're building it, but SCCP will replace the possibly-undef constant with a plain constant, and at that point the model is consistent with the transform.  It would only become problematic if we didn't eventually perform that replacement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76459/new/

https://reviews.llvm.org/D76459





More information about the llvm-commits mailing list