[PATCH] D77817: [llvm][NFC] Replace CallSite with CallBase in Inliner

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 9 12:14:23 PDT 2020


dblaikie added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Inliner.cpp:520
 
-static void setInlineRemark(CallSite &CS, StringRef message) {
+static void setInlineRemark(CallBase *CS, StringRef Message) {
   if (!InlineRemarkAttribute)
----------------
Yeah - this looks like Harbormaster just couldn't tell you didn't introduce this problem (the 'message' name not following LLVM naming conventions) - so I'd generally advise ignoring such a suggestion, or fixing it in an independent commit - no big deal/wouldn't bother fussing about it if you'd rather just commit it together this time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77817/new/

https://reviews.llvm.org/D77817





More information about the llvm-commits mailing list