[PATCH] D77787: [MLIR] Introduce a trait that defines a new scope for auto allocation

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula marked 2 inline comments as done.
bondhugula added inline comments.


================
Comment at: mlir/include/mlir/IR/OpDefinition.h:1039
+  static LogicalResult verifyTrait(Operation *op) {
+    if (op->getNumRegions() == 0)
+      return op->emitOpError("is expected to have regions");
----------------
rriddle wrote:
> What happens if the operation has a variadic number of regions?
That should be fine. The allocations of each are still to be freed when control transfers from that respective region to the op. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77787/new/

https://reviews.llvm.org/D77787