[PATCH] D74539: [KnownBits] Avoid copying KnownBits objects

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 9 10:37:55 PDT 2020


RKSimon added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:1097
 
-  KnownBits Known2(Known);
+  KnownBits Known2(BitWidth);
   switch (I->getOpcode()) {
----------------
foad wrote:
> RKSimon wrote:
> > Not sure about the std::move but using BitWidth makes sense to me.
> I took the liberty of committing these bits in 94cc9eccf65f2282ae780c3e98d19c5b3b6b9069.
LGTM, cheers


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74539/new/

https://reviews.llvm.org/D74539





More information about the llvm-commits mailing list