[PATCH] D77787: [MLIR] Introduce a trait that defines a new scope for auto allocation

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula added a comment.

In D77787#1971994 <https://reviews.llvm.org/D77787#1971994>, @ftynse wrote:

> Most traits are not an `OperationProperty`, it suffices to have a quick look in OpBase.td and see ~30 different traits being used. While we should add documentation to this enum (ping @rriddle), this is not precluding you from just defining a trait and landing it.


Just using a trait that doesn't use an OperationProperty bit is pretty straightforward, but simply landing the patch quickly isn't the point. What's more important here is to have the understanding and information documented on when something is a trait and an 'OperationProperty' as well - for the benefit of those adding traits in the future. This should go into the doc comment on 'OperationProperty'. I'm assuming you aren't blocked by this revision.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77787/new/

https://reviews.llvm.org/D77787