[PATCH] D77663: WIP: [MLIR] Lower vector slices while lowering linalg to LLVM.

[Aart Bik via Phabricator via llvm-commits]

aartbik added inline comments.


================
Comment at: mlir/lib/Conversion/LinalgToLLVM/LinalgToLLVM.cpp:583
   populateVectorToLLVMMatrixConversionPatterns(converter, patterns);
+  lowerVectorSlicesToLLVM(getModule(), &getContext());
   populateVectorToLLVMConversionPatterns(converter, patterns);
----------------
nit: I would move this down with white space around it.  Reason, all others populate for the apply method below, this one already applies


================
Comment at: mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp:1120
 
+void mlir::lowerVectorSlicesToLLVM(Operation *op, MLIRContext *context) {
+  OwningRewritePatternList patterns;
----------------
nit: slightly more general name, we are packing more and more vector-vector lowerings into this set? (I have another one pending :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77663/new/

https://reviews.llvm.org/D77663