[PATCH] D77788: [PowerPC][Future] Enable Tail Calls for PC Relative Code

[Kamau Bridgeman via Phabricator via llvm-commits]

kamaub added inline comments.
Herald added a subscriber: wuzish.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1548
     // 5) This function uses inline asm. We mark R2 as reserved if the function
     //    has inline asm so we have to assume that it may be used.
+    if (MF->getFrameInfo().hasCalls() || MF->getFrameInfo().hasTailCall() ||
----------------
Update the comment to reflect the added condition.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5588
              "Callee should be an llvm::Function object.");
-      LLVM_DEBUG(
-          const GlobalValue *GV =
-              cast<GlobalAddressSDNode>(Callee)->getGlobal();
-          const unsigned Width =
-              80 - strlen("TCO caller: ") - strlen(", callee linkage: 0, 0");
-          dbgs() << "TCO caller: "
-                 << left_justify(DAG.getMachineFunction().getName(), Width)
-                 << ", callee linkage: " << GV->getVisibility() << ", "
-                 << GV->getLinkage() << "\n");
+      if (isa<GlobalAddressSDNode>(Callee)) {
+        LLVM_DEBUG(
----------------
Please put condition inside an `#ifndef NDEBUG` block, there may be flags for an empty if condition when building without asserts otherwise.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77788/new/

https://reviews.llvm.org/D77788