[llvm] 45ab677 - [NFC] Fix Z3 version detection regexp

Balazs Benics via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 9 04:06:51 PDT 2020


Author: Balazs Benics
Date: 2020-04-09T13:06:22+02:00
New Revision: 45ab67721e900801e79d7e993cf61de2065035f7

URL: https://github.com/llvm/llvm-project/commit/45ab67721e900801e79d7e993cf61de2065035f7
DIFF: https://github.com/llvm/llvm-project/commit/45ab67721e900801e79d7e993cf61de2065035f7.diff

LOG: [NFC] Fix Z3 version detection regexp

Summary:
We use the `major.minor.build` version format in this file, except when we try
to parse the result of the test binary.
In that regular expression, we expect the `major.minor.build.rev` format, which
is never fulfilled.

Reviewers: NoQ, george.karpenkov, alexandre.isoard, serge-sans-paille

Reviewed By: NoQ

Subscribers: mgorny, mikhail.ramalho, Charusso, martong, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D76837

Added: 
    

Modified: 
    llvm/cmake/modules/FindZ3.cmake

Removed: 
    


################################################################################
diff  --git a/llvm/cmake/modules/FindZ3.cmake b/llvm/cmake/modules/FindZ3.cmake
index 04294275535b..95dd37789a87 100644
--- a/llvm/cmake/modules/FindZ3.cmake
+++ b/llvm/cmake/modules/FindZ3.cmake
@@ -27,7 +27,7 @@ function(check_z3_version z3_include z3_lib)
   )
 
   if(Z3_COMPILED)
-    string(REGEX REPLACE "([0-9]*\\.[0-9]*\\.[0-9]*\\.[0-9]*)" "\\1"
+    string(REGEX REPLACE "([0-9]*\\.[0-9]*\\.[0-9]*)" "\\1"
            z3_version "${SRC_OUTPUT}")
     set(Z3_VERSION_STRING ${z3_version} PARENT_SCOPE)
   endif()


        


More information about the llvm-commits mailing list