[PATCH] D76624: [MSan] Add instrumentation for SystemZ

[Ulrich Weigand via Phabricator via llvm-commits]

uweigand added a comment.

Just a minor cosmetic suggestion inline.  Otherwise the Z ABI parts now all LGTM.



================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:4666
+      return IsSoftFloatABI ? ArgKind::GeneralPurpose : ArgKind::FloatingPoint;
+    if (T->isIntegerTy() && T->getPrimitiveSizeInBits() <= 64)
+      return ArgKind::GeneralPurpose;
----------------
The size check now seems redundant with the i128 check.  OTOH maybe it would be preferable to move the fp128 and i128 checks to here and return a new ArgKind::Indirect -- that way all the type classification checks would be in one place.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76624/new/

https://reviews.llvm.org/D76624