[PATCH] D77750: [ELF][test] Improve reproduce tests and enable for Windows

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 9 03:13:37 PDT 2020


grimar accepted this revision.
grimar added a comment.

I am happy to see more tests enabled, thanks!
And I confirm they pass for me under windows with this change.

LGTM with 2 nits.



================
Comment at: lld/test/ELF/reproduce-thin-archive.s:15
+
+# RUN: ld.lld -m elf_x86_64 --whole-archive foo.a -o /dev/null --reproduce repro1.tar
+# RUN: tar tf repro1.tar | FileCheck -DPATH='repro1/%:t.dir' --check-prefix=CHECK1 %s
----------------
I'd perhaps leave it as `repro2.tar`, but changed the `repro.tar` above to `repro1.tar`.
(It is probably a bit confusing to see `repro1.tar` when it is known to be not the first,
but the second reproduce file in a test?)


================
Comment at: lld/test/ELF/reproduce.s:15
+# RSP1-NOT: {{^}}repro1{{[/\\]}}
+# RSP1-NEXT: {{[/\\]}}foo.o
+# RSP1-NEXT: -o bar
----------------
Lets align? (We often do this in LLVM tools test and it reads slightly better + `RSP3` checks below are aligned)

```
# RSP1:      {{^}}--hash-style gnu{{$}}
# RSP1-NOT:  {{^}}repro1{{[/\\]}}
# RSP1-NEXT: {{[/\\]}}foo.o
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77750/new/

https://reviews.llvm.org/D77750





More information about the llvm-commits mailing list